Skip to content

Conversation

@ahouseholder
Copy link
Contributor

@ahouseholder ahouseholder commented Sep 16, 2025

We can use the registered example namespace for examples. It is already set up with base classes for both ExampleDecisionPoint and ExampleDecisionTable so that it also avoids registering the decision points and tables in the registry.

Copilot Summary

This pull request refactors the example decision point and decision table implementations to use new base classes specific to examples, and updates the identifiers in the decision table mappings to match the new naming convention. The changes improve consistency and modularity in the example code.

Refactoring to use example-specific base classes:

  • Replaced usage of SsvcDecisionPoint with ExampleDecisionPoint in humidity.py and weather.py to clarify the distinction between example and SSVC decision points. [1] [2]
  • Updated to_play.py to use ExampleDecisionTable instead of the generic DecisionTable.

Naming and import consistency:

  • Standardized the import order and removed unused imports in to_play.py for clarity and consistency.

Identifier and mapping updates:

  • Changed decision point and outcome identifiers in the mapping section of to_play.py from the old x_example.test#forecast format to the new example namespace to match the updated decision point definitions.

@ahouseholder ahouseholder added tech/backend Back-end tools, code, infrastructure tech/data Data implementation (content of /data, data object instances, etc.) labels Sep 16, 2025
@ahouseholder ahouseholder added this to the 2025-09 milestone Sep 16, 2025
Copy link
Contributor

@sei-vsarvepalli sei-vsarvepalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know ExampleDecisionTable exists.

@ahouseholder ahouseholder merged commit 2add020 into main Sep 16, 2025
5 checks passed
@ahouseholder ahouseholder deleted the clean-up-examples branch September 16, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tech/backend Back-end tools, code, infrastructure tech/data Data implementation (content of /data, data object instances, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants